Use vs-pwsh icons if applicable.#19990
Open
teo-tsirpanis wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR updates
VsDevShellGeneratorto use thevs-pwshicon in generated profiles, if modern PowerShell has been detected.References and Relevant Issues
The icons were added in #17706, but are not used anywhere.
Detailed Description of the Pull Request / Additional comments
VsDevShellGenerator::GetProfileCommandLineto accept abool& isPwshparameter, which is set to whether the generated profile command line is using modern PowerShell. This value gets passed toVsDevShellGenerator::GetProfileIconPath's new parameter, which determines whether to return the icon forpowershellorpwsh.Validation Steps Performed
PR Checklist