Fix #59: Preserve @odata.type fields in PATCH requests #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issue microsoft#59 where PATCH operations fail for polymorphic Microsoft Graph resources (like namedLocations) that require @odata.type discriminator fields to always be present. Changes: - Modified DiffObject() in internal/utils/json.go to always include @OData.* fields when there are other changes, even if those fields haven't changed themselves - Added comprehensive test cases for various @OData.* field scenarios - Added acceptance test TestAcc_ResourceNamedLocationWithODataType to verify the fix works with real Microsoft Graph API endpoints The fix ensures that: 1. @odata.type and other @OData.* fields are preserved in PATCH requests 2. The optimization from PR microsoft#47 (minimal PATCH payloads) is maintained 3. Issue microsoft#36 (navigation property errors) is not reintroduced Fixes: microsoft#59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issue #59 where PATCH operations fail for polymorphic Microsoft Graph resources (like namedLocations) that require @odata.type discriminator fields to always be present.
Changes:
The fix ensures that:
Fixes: #59