-
Couldn't load subscription status.
- Fork 5
engineering: Fix warnings #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses compiler warnings from newer Rust versions by cleaning up unused code and fixing lifetime parameter annotations.
Key changes:
- Removes unused struct definitions and imports that are no longer referenced
- Adds explicit lifetime parameters to fix elided lifetime warnings in trait bounds and return types
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/trident/src/subsystems/extensions/mod.rs | Suppresses unused warning for populate_extensions function |
| crates/trident/src/osimage/mod.rs | Adds explicit lifetime parameters to filesystem-related methods |
| crates/trident/src/osimage/cosi/mod.rs | Adds explicit lifetime parameters to filesystem methods |
| crates/trident/src/engine/storage/raid.rs | Removes unused RaidState enum and associated imports |
| crates/trident/src/engine/storage/encryption.rs | Removes unused LUKS dump structures and imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes various warnings from newer Rust versions.