Skip to content

Conversation

@fintelia
Copy link
Contributor

Fixes various warnings from newer Rust versions.

Copilot AI review requested due to automatic review settings October 27, 2025 20:22
@fintelia fintelia requested a review from a team as a code owner October 27, 2025 20:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses compiler warnings from newer Rust versions by cleaning up unused code and fixing lifetime parameter annotations.

Key changes:

  • Removes unused struct definitions and imports that are no longer referenced
  • Adds explicit lifetime parameters to fix elided lifetime warnings in trait bounds and return types

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
crates/trident/src/subsystems/extensions/mod.rs Suppresses unused warning for populate_extensions function
crates/trident/src/osimage/mod.rs Adds explicit lifetime parameters to filesystem-related methods
crates/trident/src/osimage/cosi/mod.rs Adds explicit lifetime parameters to filesystem methods
crates/trident/src/engine/storage/raid.rs Removes unused RaidState enum and associated imports
crates/trident/src/engine/storage/encryption.rs Removes unused LUKS dump structures and imports

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

bfjelds
bfjelds previously approved these changes Oct 27, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings October 27, 2025 20:35
fintelia and others added 4 commits October 27, 2025 13:35
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings October 27, 2025 20:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frhuelsz
frhuelsz previously approved these changes Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants