Conversation
|
oh. there's more diet to do... note that it's all shipped twice 😛 - just the |
|
@microsoft-github-policy-service agree |
|
@iclanton - the CI seems stuck... help? |
|
@osher - I'll take a look this week. |
|
You need to run |
tsdoc/package.json
Outdated
| "lib-commonjs/*.js", | ||
| "lib-commonjs/*.js.map", |
There was a problem hiding this comment.
These (and the patterns for lib) only match files in the root of the lib-commonjs folder. This project has files that are in nested folders.
There was a problem hiding this comment.
gotcha! will fix
will also remove the .js.map per your comment below
...cound't get rush working for me though...
|
this will reduce your on-disk node_modules footprint from ~500K to ~80K.
I mean, good work with the tests and all, but don't ship them...
You also don't need to ship map files for
ts.P.S.
I would put more accurate numbers like I did for
resolve- (which BTW affects you too!), butnpm ifails...I saw you use a different toolchain, but could not get started with this
rush. all kinds of wierd errors... :P I had to give up.