[typespec-vscode] show NoTarget diagnostic message in vscode #8757
+96
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
compiler:core
commit: |
|
All changed packages have been documented.
|
RodgeFu
reviewed
Oct 31, 2025
| emitterName: string | undefined = undefined, | ||
| ): Promise<VSLocation | typeof NoTarget | undefined> { | ||
| if (configFilePath && emitterName && emitterName.length > 0 && location === undefined) { | ||
| const [yamlScript] = parseYaml(await NodeSystemHost.readFile(configFilePath)); |
There was a problem hiding this comment.
why do we need to load the yaml here? I think we did the same thing for the import error in tspconfig.yaml but didn't need this change.
RodgeFu
reviewed
Oct 31, 2025
| diagnostic: Diagnostic, | ||
| ): [VSDiagnostic, TextDocument][] { | ||
| const root = getVSLocation( | ||
| emitters?: string[] | undefined, |
There was a problem hiding this comment.
emitters is confusing here, better to pass in the settings directly
RodgeFu
reviewed
Oct 31, 2025
| if (root === NoTarget) { | ||
| let customMsg = ""; | ||
| if (emitters && emitters.includes(emitterName || "")) { | ||
| customMsg = ". It's configured in vscode settings."; |
There was a problem hiding this comment.
" [...]", ". " may not be correct because you dont know the original message
RodgeFu
reviewed
Oct 31, 2025
| let customMsg = ""; | ||
| if (emitters && emitters.includes(emitterName || "")) { | ||
| customMsg = ". It's configured in vscode settings."; | ||
| } |
There was a problem hiding this comment.
else {
... [No target source location reported for this Error/Warning]
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #8539.
show NoTarget diagnostic message in vscode