Skip to content

Convert namespace segments to PascalCase in C# generator #8824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshLove-msft merged 10 commits into from
Nov 3, 2025
Merged

Convert namespace segments to PascalCase in C# generator #8824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fecdeda
Initial plan
Copilot Oct 27, 2025
9697f49
Implement PascalCase transformation for namespace segments in GetClea…
Copilot Oct 27, 2025
5700069
Add additional test cases for namespace PascalCase transformation
Copilot Oct 27, 2025
29a30e5
Refactor GetCleanNameSpace to use minimal changes for PascalCase tran…
Copilot Oct 27, 2025
721f0e6
Minimize changes to GetCleanNameSpace - keep original loop structure
Copilot Oct 27, 2025
22aba4f
Keep stackalloc approach - apply ToIdentifierName without changing bu…
Copilot Oct 27, 2025
fd89b75
Remove duplicate logic - delegate string overload to existing span me…
Copilot Oct 27, 2025
f98556f
Use span for IsSpecialSegment check, only convert to string for ToIde…
Copilot Oct 27, 2025
25c484c
Revert global.json changes - restore SDK version to 9.0.306
Copilot Oct 27, 2025
8ffc1f9
Fix special segments bug - check after PascalCase transformation, add…
Copilot Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/TypeFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,25 +389,27 @@ public string GetCleanNameSpace(string clientNamespace)
while (nextDot != -1)
{
var segment = source.Slice(0, nextDot);
if (IsSpecialSegment(segment))
var segmentStr = segment.ToString();
var cleanedSegment = segmentStr.ToIdentifierName();
if (IsSpecialSegment(cleanedSegment))
{
dest[destIndex] = '_';
destIndex++;
cleanedSegment = "_" + cleanedSegment;
}
segment.CopyTo(dest.Slice(destIndex));
destIndex += segment.Length;
cleanedSegment.AsSpan().CopyTo(dest.Slice(destIndex));
destIndex += cleanedSegment.Length;
dest[destIndex] = '.';
destIndex++;
source = source.Slice(nextDot + 1);
nextDot = source.IndexOf('.');
}
if (IsSpecialSegment(source))
var lastSegmentStr = source.ToString();
var cleanedLastSegment = lastSegmentStr.ToIdentifierName();
if (IsSpecialSegment(cleanedLastSegment))
{
dest[destIndex] = '_';
destIndex++;
cleanedLastSegment = "_" + cleanedLastSegment;
}
source.CopyTo(dest.Slice(destIndex));
destIndex += source.Length;
cleanedLastSegment.AsSpan().CopyTo(dest.Slice(destIndex));
destIndex += cleanedLastSegment.Length;
return dest.Slice(0, destIndex).ToString();
}

Expand All @@ -424,6 +426,8 @@ private bool IsSpecialSegment(ReadOnlySpan<char> readOnlySpan)
return false;
}

private bool IsSpecialSegment(string segment) => IsSpecialSegment(segment.AsSpan());

private static int GetSegmentCount(string clientNamespace)
{
int count = 0;
Expand Down
29 changes: 29 additions & 0 deletions packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/test/TypeFactoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,5 +162,34 @@ public void CreatesFrameworkType(Type expectedType)
var actual = factory.InvokeCreateFrameworkType(expectedType.FullName!);
Assert.AreEqual(expectedType, actual);
}

[TestCase("lowercase", "Lowercase")]
[TestCase("lowercase.namespace", "Lowercase.Namespace")]
[TestCase("lowercase.namespace.client", "Lowercase.Namespace.Client")]
[TestCase("PascalCase", "PascalCase")]
[TestCase("PascalCase.Namespace", "PascalCase.Namespace")]
[TestCase("camelCase", "CamelCase")]
[TestCase("camelCase.namespace", "CamelCase.Namespace")]
[TestCase("kebab-case", "KebabCase")]
[TestCase("kebab-case.namespace", "KebabCase.Namespace")]
[TestCase("snake_case", "SnakeCase")]
[TestCase("snake_case.namespace", "SnakeCase.Namespace")]
[TestCase("mixed_case-namespace.example", "MixedCaseNamespace.Example")]
[TestCase("number123", "Number123")]
[TestCase("number123.namespace", "Number123.Namespace")]
[TestCase("UPPERCASE", "UPPERCASE")]
[TestCase("UPPERCASE.NAMESPACE", "UPPERCASE.NAMESPACE")]
[TestCase("type.union", "_Type.Union")]
[TestCase("type.array", "_Type._Array")]
[TestCase("array.foo", "_Array.Foo")]
[TestCase("enum.bar", "_Enum.Bar")]
[TestCase("Type.Union", "_Type.Union")]
[TestCase("Array.Foo", "_Array.Foo")]
[TestCase("Enum.Bar", "_Enum.Bar")]
public void GetCleanNameSpace_ConvertsToPascalCase(string input, string expected)
{
var actual = CodeModelGenerator.Instance.TypeFactory.GetCleanNameSpace(input);
Assert.AreEqual(expected, actual);
}
}
}
Loading