Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Conversation

@DawidB
Copy link

@DawidB DawidB commented Nov 21, 2022

Update node to v16 in order to prevent node version warning on dependent wokflows.

@patrick-scully-ef
Copy link

+1 vote for this PR

@onabison
Copy link

Does this mean we're going to get those deprecation notifications until this PR gets approved and merged?

Copy link

@onabison onabison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple update, looks harmless enough... who needs to approve?

@rajbos
Copy link

rajbos commented Nov 30, 2022

I had to do a bit more to get this working with node 16, so it needs a bit more than just this PR I think.

I ran into the same issue, and have forked the action in the meantime. You can find and use v1.1 from here: github.com/rajbos-actions/variable-substitution if this is blocking.

@DawidB
Copy link
Author

DawidB commented Dec 1, 2022

Since MS deprecated this action, I guess we'll have to switch to @rajbos solution.

Copy link

@onabison onabison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who do I need to sleep with for this merge to happen?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants