InlineChatIntent #1549
Draft
InlineChatIntent #1549
+2,833
−3,962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…diagnostics will never be read but slow down the result
auto-merge was automatically disabled
October 23, 2025 16:13
Pull request was converted to draft
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the inline chat testing strategy by renaming Inline2 to InlineChatIntent throughout the test codebase. The change reflects a more descriptive naming convention that better represents the inline chat intent interaction being tested.
Key Changes
- Renamed
EditTestStrategy.Inline2toEditTestStrategy.InlineChatIntent - Updated all test files to use the new
forInlineAndInlineChatIntenthelper instead offorInlineAndInline2 - Refactored
simulateInlineChat3function tosimulateInlineChatIntentwith enhanced diagnostic reference support - Updated baseline test data and outcome files to reflect the naming changes
Reviewed Changes
Copilot reviewed 65 out of 65 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/simulation/types.ts | Renamed enum value and updated documentation comment |
| test/simulation/inlineChatSimulator.ts | Refactored simulation function with new name and added diagnostic reference contribution logic |
| test/simulation/slash-test/testGen.ts.stest.ts | Updated imports and test suite configuration to use new naming |
| test/simulation/slash-test/testGen.csharp.stest.ts | Updated imports and helper function calls |
| test/simulation/slash-test/testGen.cpp.stest.ts | Updated imports and helper function calls |
| test/simulation/baseline.json | Updated test baseline names from inline2 to InlineChatIntent |
| test/outcome/*.json | Updated test outcome file names and request hashes |
| test/simulation/cache/layers/*.sqlite | Added new cached test layer files |
jrieken
commented
Oct 23, 2025
| } | ||
|
|
||
| const diagnostics = !this.testContext.isInSimulationTests && this.configurationService.getExperimentBasedConfig(ConfigKey.AutoFixDiagnostics, this.experimentationService) && !(file.isNotebook) | ||
| const diagnostics = (this.props.diagnosticsTimeout === undefined || this.props.diagnosticsTimeout >= 0) |
There was a problem hiding this comment.
fyi @roblourens - I know there is a discussion around this feature and I don't wanna get to involved in that, but for inline chat we really don't need to wait for diagnostics because the tool result won't be fed back to the LM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.