Remove error handling from inline suggestions #273110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes error tracking infrastructure from the inline completions/suggestions system. The changes eliminate the ability to report and propagate errors through the inline edit lifecycle, including removing error properties from telemetry events and data structures.
Key Changes
- Removed error tracking from inline completion telemetry events and lifetime summaries
- Eliminated the
abort()method andreportInlineEditError()functionality from inline edit models - Changed error handling to use
onUnexpectedError()instead of model-level error reporting
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/api/browser/mainThreadLanguageFeatures.ts | Removed error field from lifetime summary telemetry |
| src/vs/editor/contrib/inlineCompletions/browser/view/inlineEdits/inlineEditsViewInterface.ts | Removed abort() method from IInlineEditModel interface |
| src/vs/editor/contrib/inlineCompletions/browser/view/inlineEdits/inlineEditsView.ts | Changed from model.abort() to onUnexpectedError() for error reporting |
| src/vs/editor/contrib/inlineCompletions/browser/view/inlineEdits/inlineEditsModel.ts | Removed abort() method implementation |
| src/vs/editor/contrib/inlineCompletions/browser/telemetry.ts | Removed error field from telemetry event types and classifications |
| src/vs/editor/contrib/inlineCompletions/browser/model/provideInlineCompletions.ts | Removed error field from InlineSuggestViewData and reportInlineEditError() method |
| src/vs/editor/contrib/inlineCompletions/browser/model/inlineSuggestionItem.ts | Removed reportInlineEditError() method |
| src/vs/editor/common/languages.ts | Removed error field from LifetimeSummary type |
src/vs/editor/contrib/inlineCompletions/browser/view/inlineEdits/inlineEditsView.ts
Outdated
Show resolved
Hide resolved
…ts/inlineEditsView.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Tyriar
previously approved these changes
Oct 24, 2025
|
@benibenj red CI |
aeschli
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Remove error properties and related handling from inline suggestion data structures and methods. This includes eliminating error reporting and associated logic throughout the relevant classes and interfaces.