Improve history item label text legibility in SCM view #273118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adge color present to increase legibility. Replace historyItemHoverLabelForeground with PANEL_BACKGROUND and update import to ensure label text contrasts against colored badges. Removed unused import.
There was a problem hiding this comment.
Pull Request Overview
This PR improves the readability of history item labels in the SCM view by adjusting the text color for labels displayed over colored badges. The change uses the panel background color instead of a hover-specific foreground color to enhance contrast against colored badges.
Key changes:
- Updated text color logic to use
PANEL_BACKGROUNDfor better contrast on colored badges - Removed unused
historyItemHoverLabelForegroundimport
mrleemurray
added
ux
|
@microsoft-github-policy-service rerun |
1 similar comment
|
@microsoft-github-policy-service rerun |
lszomoru
requested changes
Oct 27, 2025
…ort token Change historyItemHoverLabelForeground default to the panel background token and export the identifier for use in the view pane. Use the exported token in scmHistoryViewPane and remove the now-unused buttonForeground import.
lszomoru
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the contrast of history item labels against colored badges by using the panel background color, improving overall readability. Remove unused imports for cleaner code.
Before:
After:
