feat: implement MCP server deduplication with comprehensive key generation #273320
+382
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation - Add deduplication logic to prevent duplicate server definitions - Use McpServerLaunch.hash() for comprehensive key generation including: - Variable resolution through existing infrastructure - Environment variables in hash calculation - HTTP headers for HTTP servers - Implement priority-based deduplication (user > workspace > extensions) - Add proper telemetry tracking with typed data structures - Add comprehensive test suite following VS Code patterns - Addresses reviewer feedback on variable resolution and environment variables Fixes: Server deduplication now properly handles all launch configuration properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements comprehensive MCP server deduplication to prevent duplicate server definitions across different collections, addressing the feedback from PR #272936.
Changes Made
McpServerLaunch.hash()method which handles all launch configuration properties including:Addresses Reviewer Feedback
McpServerLaunch.hash()infrastructureRelated
CC: @torsknod2 (reviewer from original PR)