Skip to content

Conversation

@justschen
Copy link
Collaborator

special setting that includes ALL tool calls inside the thinking container. special case handling for create tool.

Copilot AI review requested due to automatic review settings October 25, 2025 23:56
@vs-code-engineering
Copy link

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@roblourens

Matched files:

  • src/vs/workbench/contrib/chat/browser/chatListRenderer.ts

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds special handling for tool invocations in the chat thinking display, introducing a new configuration option to collapse tool calls inside thinking blocks by default, with special behavior for "create" tool invocations.

  • Adds a new configuration chat.agent.thinking.collapsedTools to control whether tool calls appear inside thinking blocks
  • Implements special case handling to keep thinking active for "create" tool invocations
  • Adds logic to determine when to pin tool invocations based on the thinking style and configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/vs/workbench/contrib/chat/browser/chatListRenderer.ts Adds isCreateToolInvocationContent() helper method, updates shouldPinPart() to check the new configuration, and modifies thinking finalization logic to handle create tools specially
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Registers the new chat.agent.thinking.collapsedTools configuration option
Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/chatListRenderer.ts:1751

  • Missing closing brace - the if statement at line 1296 appears to have an extra closing brace at line 1305, causing the logic block to end prematurely. This creates a mismatched brace structure.
	}
}

@justschen justschen merged commit bcb34d6 into microsoft:main Oct 26, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants