-
Couldn't load subscription status.
- Fork 35.8k
Updates to Go To quick access #273668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Updates to Go To quick access #273668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes several bugs and improves the user experience of the "Go to Line" quick access feature:
- Fixed async setting persistence for zero-based offset toggle
- Fixed navigation to line numbers exceeding file line count
- Updated UI guidance text and removed redundant status information
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/codeEditor/browser/quickaccess/gotoLineQuickAccess.ts | Updated placeholder text to include comprehensive usage instructions for offset mode and negative values |
| src/vs/editor/contrib/quickAccess/test/browser/gotoLineQuickAccess.test.ts | Updated test assertions to handle default column value and corrected expected line numbers for out-of-range inputs |
| src/vs/editor/contrib/quickAccess/browser/gotoLineQuickAccess.ts | Refactored offset toggle handling with getter/setter for async persistence, simplified validation logic, and enhanced label generation with contextual guidance |
src/vs/workbench/contrib/codeEditor/browser/quickaccess/gotoLineQuickAccess.ts
Show resolved
Hide resolved
|
Copilot, for this one here's how I want you to test...
For all of these, try:
|
|
🤖 Copilot has tried out this change! Members of the team can view the recording here (run) |
X |

Fixed bug where zero-based offset toggle did not always work (updating the setting async now).
Fixed bug where going to line number greater than lines in file wasn't working.
Updated description (tooltip) of the quick pick to include offset and negative values information.
Removed second line in the pick item.
Updated guidance text to more closely follow the grammar and offer instructions for entering column and offset numbers.
Due to length limitations, I removed current line/column displayed in the pick item label before - this information is alaready available in the status bar, so I think it's ok to do so.