Skip to content

Conversation

@dmitrivMS
Copy link
Contributor

Fixed bug where zero-based offset toggle did not always work (updating the setting async now).
Fixed bug where going to line number greater than lines in file wasn't working.
Updated description (tooltip) of the quick pick to include offset and negative values information.
Removed second line in the pick item.
Updated guidance text to more closely follow the grammar and offer instructions for entering column and offset numbers.

Due to length limitations, I removed current line/column displayed in the pick item label before - this information is alaready available in the status bar, so I think it's ok to do so.

Copilot AI review requested due to automatic review settings October 28, 2025 00:22
@dmitrivMS dmitrivMS enabled auto-merge (squash) October 28, 2025 00:22
@dmitrivMS dmitrivMS self-assigned this Oct 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes several bugs and improves the user experience of the "Go to Line" quick access feature:

  • Fixed async setting persistence for zero-based offset toggle
  • Fixed navigation to line numbers exceeding file line count
  • Updated UI guidance text and removed redundant status information

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/vs/workbench/contrib/codeEditor/browser/quickaccess/gotoLineQuickAccess.ts Updated placeholder text to include comprehensive usage instructions for offset mode and negative values
src/vs/editor/contrib/quickAccess/test/browser/gotoLineQuickAccess.test.ts Updated test assertions to handle default column value and corrected expected line numbers for out-of-range inputs
src/vs/editor/contrib/quickAccess/browser/gotoLineQuickAccess.ts Refactored offset toggle handling with getter/setter for async persistence, simplified validation logic, and enhanced label generation with contextual guidance

@vs-code-engineering vs-code-engineering bot added this to the October 2025 milestone Oct 28, 2025
@dmitrivMS
Copy link
Contributor Author

GIF of new behavior:
Recording 2025-10-27 at 19 16 28

@TylerLeonhardt TylerLeonhardt added the ~copilot-video-please ⚠️WIP🏗️ Use in PRs. Runs Copilot CLI agent to record a video of "trying out the change" label Oct 28, 2025
@vs-code-engineering vs-code-engineering bot removed the ~copilot-video-please ⚠️WIP🏗️ Use in PRs. Runs Copilot CLI agent to record a video of "trying out the change" label Oct 28, 2025
@TylerLeonhardt TylerLeonhardt added the ~copilot-video-please ⚠️WIP🏗️ Use in PRs. Runs Copilot CLI agent to record a video of "trying out the change" label Oct 28, 2025
@vs-code-engineering vs-code-engineering bot removed the ~copilot-video-please ⚠️WIP🏗️ Use in PRs. Runs Copilot CLI agent to record a video of "trying out the change" label Oct 28, 2025
@TylerLeonhardt
Copy link
Member

Copilot, for this one here's how I want you to test...

  • Try using the Go To quick access putting in:
    • a line number
    • a line number then a colon then line number
    • another colon (to drop into offset mode)

For all of these, try:

  • negative numbers
  • numbers that are larger than the size of the file

@TylerLeonhardt TylerLeonhardt added the ~copilot-video-please ⚠️WIP🏗️ Use in PRs. Runs Copilot CLI agent to record a video of "trying out the change" label Oct 28, 2025
@microsoft microsoft deleted a comment from vs-code-engineering bot Oct 28, 2025
@vs-code-engineering vs-code-engineering bot removed the ~copilot-video-please ⚠️WIP🏗️ Use in PRs. Runs Copilot CLI agent to record a video of "trying out the change" label Oct 28, 2025
@vs-code-engineering
Copy link

🤖 Copilot has tried out this change! Members of the team can view the recording here (run)

@jojemoro2609-lgtm
Copy link

Fixed bug where zero-based offset toggle did not always work (updating the setting async now). Fixed bug where going to line number greater than lines in file wasn't working. Updated description (tooltip) of the quick pick to include offset and negative values information. Removed second line in the pick item. Updated guidance text to more closely follow the grammar and offer instructions for entering column and offset numbers.

Due to length limitations, I removed current line/column displayed in the pick item label before - this information is alaready available in the status bar, so I think it's ok to do so.

X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants