Skip to content

Fix hand cursor showing when notebook drag and drop is disabled #282365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix hand cursor showing when notebook drag and drop is disabled #282365

Copilot wants to merge 2 commits into from
+5 −2

Conversation

Copy link
Contributor

Copilot AI commented Dec 10, 2025 •
edited
Loading

Description

The grab cursor was unconditionally displayed on notebook cells regardless of the notebook.dragAndDropEnabled setting state.

Changes

CSS Class Control (notebookEditorWidget.ts)

  • Toggle notebook-dnd-disabled class on overlay container based on dragAndDropEnabled option
  • Applied in _updateForNotebookConfiguration() to react to setting changes

Conditional Cursor Style (notebookFocusIndicator.css)

  • Updated selectors with :not(.notebook-dnd-disabled) to gate grab cursor application
  • Affects both code cell focus indicators and markdown cell containers

The drag functionality already checks the setting before allowing drags—this fix aligns the visual feedback.

Original prompt

This section details on the original issue you should resolve

<issue_title>Hand mouse pointer is shown when drag and drop is disabled</issue_title>
<issue_description>Testing #125013

Kapture 2021-06-02 at 09 16 02

</issue_description>

<agent_instructions>Perform a root cause analysis before attempting to fix this.
</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@roblourens Good catch @DonJayamanne No longer able to repro this. @Yoyokrazy issue still persists for code cells, however is fixed for markdown cells.

https://github.com/user-attachments/assets/5783c7e3-9160-4d72-9045-73d1fe251be3</comment_new>

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@DonJayamanne
Fix hand cursor showing when drag and drop is disabled
5a132dc 
Add notebook-dnd-disabled class to overlay container when drag-and-drop is disabled.
Update CSS to only show grab cursor when drag-and-drop is enabled.

Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix hand mouse pointer display when drag and drop is disabled Fix hand cursor showing when notebook drag and drop is disabled Dec 10, 2025
Copilot AI requested a review from DonJayamanne December 10, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

At least 1 approving review is required to merge this pull request.

Assignees

@DonJayamanne DonJayamanne

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hand mouse pointer is shown when drag and drop is disabled

2 participants

@DonJayamanne