Fix: Prevent LogMonitor crash when log line exceeds 4000 characters #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…characters Signed-off-by: Charity Kathure <ckathure@microsoft.com>
CharityKathure
requested review from
TinaMor,
billywr,
bobsira and
danielGithinji
profnandaa
approved these changes
Jul 1, 2025
| std::string sanitized; | ||
| sanitized.reserve(inputLine.size()); | ||
| for (char c : inputLine) { | ||
| sanitized += (c > 0) ? c : '?'; |
Contributor
There was a problem hiding this comment.
we didn't support multi-byte (wide) characters then when we were using char* , now that we moved to std::string, could we consider supporting as the next step, perhaps not on this PR. Might come with some perf hits...
Contributor
Author
There was a problem hiding this comment.
I have added this to our backlog. Thanks.
billywr
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where LogMonitor crashes the wrapped process if a log line exceeds 4000 characters.
The previous implementation read directly into a fixed-size buffer and attempted to format/process each chunk as a complete log line. When a line exceeded the buffer size, it resulted in malformed output or unsafe memory access, ultimately crashing the wrapped process.
Changes:
ReadFromPiperefactor:FormatProcessLog,FormatCustomLogandFormatStandardLognow take conststd::stringinstead ofchar*)