Fix JSON parser to correctly handle numeric values #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloskot
approved these changes
Aug 8, 2025
Contributor
mloskot
left a comment
mloskot
left a comment
There was a problem hiding this comment.
I've tested this fix as part of testing #215 (comment), where I confirmed
The fix for ordering of the
waitInSecondsseem to work.
iankingori
approved these changes
Aug 8, 2025
fjs4
approved these changes
Aug 8, 2025
Contributor
|
Forgive me the nudge, but can we have this merged and released ASAP? I do need builds of my images stop suffering from this issue 😊 |
TinaMor
approved these changes
Aug 12, 2025
Contributor
Author
|
@mloskot this is now merged. We are aiming for a release in a couple of days. |
Contributor
|
@bobsira Awesome, thank you! |
Contributor
Author
|
https://github.com/microsoft/windows-container-tools/releases/tag/v2.1.3 we have a release with this change. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix involved removing an unnecessary increment (offset++) before advancing the buffer pointer in the ParseNumber() function of your JSON parser. Previously, after parsing a numeric value, the code advanced the offset one extra character, which caused the parser to skip over important JSON structural characters like commas (,) or closing braces (}) that separate or terminate object members. This led to errors when parsing numbers that were not the last member in an object.
By eliminating the extra increment, the parser now correctly leaves the structural character in place for the next parsing step, ensuring proper handling of multi-digit numbers and correct traversal of JSON objects regardless of the order of their members. This change makes the parser robust and compliant with standard JSON syntax, preventing premature end-of-object errors.