-
Couldn't load subscription status.
- Fork 5.6k
Implement Submodules for YamlCreate #274263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I wonder if we're getting closer to the point where we could have some "Microsoft.WinGet.Something" module (potentially leveraging wingetcreate) to make it easier to generate/test manifests. I don't want to block YAMLCreate on wingetcreate, but I know we're going to need/want PowerShell parity for PowerShell users. |
We probably could. If wingetcreate had PowerShell modules, that would be interesting |
|
I think we'd include the binary in the module for that particular use case. |
In an attempt to break YamlCreate down into easier to manage pieces, I've begun to implement some portions as PowerShell modules. This PR does the following:
Adds VirtualTerminal sequences as a Module
Removes the
Write-MultiColorLinefunction and uses the sequences from the VirtualTerminal module insteadMoves installer type detection to a separate module
Improves WIX installer detection by checking the file metadata for the program which created the MSI
Adds a module for keypresses as framework for future menuing improvements
Adds a parent module which imports all the necessary sub-modules
cc @mdanish-kh @denelon
Microsoft Reviewers: Open in CodeFlow