Skip to content

Conversation

@Trenly
Copy link
Contributor

@Trenly Trenly commented Jul 15, 2025

In an attempt to break YamlCreate down into easier to manage pieces, I've begun to implement some portions as PowerShell modules. This PR does the following:

  • Adds VirtualTerminal sequences as a Module

  • Removes the Write-MultiColorLine function and uses the sequences from the VirtualTerminal module instead

  • Moves installer type detection to a separate module

  • Improves WIX installer detection by checking the file metadata for the program which created the MSI

  • Adds a module for keypresses as framework for future menuing improvements

  • Adds a parent module which imports all the necessary sub-modules

cc @mdanish-kh @denelon

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jul 15, 2025
@denelon
Copy link
Collaborator

denelon commented Jul 15, 2025

I wonder if we're getting closer to the point where we could have some "Microsoft.WinGet.Something" module (potentially leveraging wingetcreate) to make it easier to generate/test manifests. I don't want to block YAMLCreate on wingetcreate, but I know we're going to need/want PowerShell parity for PowerShell users.

@denelon denelon merged commit 6b74aef into microsoft:master Jul 15, 2025
2 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added Moderator-Approved One of the Moderators has reviewed and approved this PR and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jul 15, 2025
@Trenly Trenly deleted the Modules branch July 15, 2025 16:28
@Trenly
Copy link
Contributor Author

Trenly commented Jul 15, 2025

I wonder if we're getting closer to the point where we could have some "Microsoft.WinGet.Something" module (potentially leveraging wingetcreate) to make it easier to generate/test manifests. I don't want to block YAMLCreate on wingetcreate, but I know we're going to need/want PowerShell parity for PowerShell users.

We probably could. If wingetcreate had PowerShell modules, that would be interesting

@denelon
Copy link
Collaborator

denelon commented Jul 15, 2025

I think we'd include the binary in the module for that particular use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Moderator-Approved One of the Moderators has reviewed and approved this PR Project-File

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants