update master for publication #1335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed intermittent failures of validate.yml that would occasionally flag random doc links as being invalid. A large number of links were using the deprecated `docs.microsoft.com` host, which could be related. - Updated all links to use `learn.microsoft.com` - Removed unnecessary query parameter `tabs` - Replaced problematic apostrophe character
* Initial plan * Fix string inconsistencies in permissions-descriptions.json and add validation test Co-authored-by: jasonjoh <8966342+jasonjoh@users.noreply.github.com> * Update tests/permissions-descriptions.spec.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jasonjoh <8966342+jasonjoh@users.noreply.github.com> Co-authored-by: Jason Johnston <jasonjoh@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Add alternative validator for testing * Update alt-validate.yml * Update alt-validate.yml * Update samples.schema.json * Update alt-validate.yml * Trying another validator * Update samples.schema.json * Update samples.schema.json * Adding invalid property for testing * Update sample-queries.json * Replace JSON validator
* Update to use `HEAD` Also added `console.log` line to help debug any future errors Fixes #1248 * Update tests/validator.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request contains multiple improvements across the codebase:
- Updates documentation links from
docs.microsoft.comtolearn.microsoft.comdomain across all sample queries - Removes trailing periods from permission display names for consistency
- Fixes JSON schema validation by changing
itemsfrom array to object format - Updates GitHub Actions workflow to use modern action versions
- Adds new test file for validating permission descriptions
- Updates validator to use HEAD requests and improve error logging
- Adds and modifies various permission configurations
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sample-queries/sample-queries.json | Updated all Microsoft documentation URLs from docs.microsoft.com to learn.microsoft.com and removed query parameters |
| permissions/permissions-descriptions.json | Removed trailing periods from display names for consistency |
| tests/samples.schema.json | Fixed schema by changing items from tuple validation (array) to object format and added $schema property |
| tests/permissions-descriptions.spec.js | Added new test file to validate permission display names for trailing/leading spaces and periods |
| tests/validator.js | Changed fetch method to HEAD for link validation and added error logging |
| permissions/new/provisioningInfo.json | Updated permission keys and added new permission entries |
| permissions/new/permissions.json | Extensive permission path and configuration updates |
| .github/workflows/validate.yml | Updated to use modern action versions and new JSON schema validation action |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jasonjoh
previously approved these changes
Nov 6, 2025
jasonjoh
previously approved these changes
Nov 10, 2025
jasonjoh
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to periodically update master for publication