Skip to content

Conversation

@sbreingold-ms
Copy link
Contributor

Important

Required for API changes:

  • [] Link to API.md file: ADD LINK HERE
  • [] Link to PR for public-facing schema changes (schema-Prod-beta/v1.0.csdl): ADD LINK HERE

Add other supporting information, such as a description of the PR changes:

ADO task: https://dev.azure.com/msft-skilling/Content/_workitems/edit/539396
MSFT dev contacts: Sharon Weiner and Faith Ombongi


Important

The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.

After you've created your PR, expand this section for tips and additional instructions.
  • do not merge is the default PR status and is automatically added to all open PRs that don't have the ready to merge label.
  • Add the ready for content review label to start a review. Only PRs that have met the minimum requirements for content review and have this label are reviewed.
  • If your content reviewer requests changes, review the feedback and address accordingly as soon as possible to keep your pull request moving forward. After you address the feedback, remove the changes requested label, add the review feedback addressed label, and select the Re-request review icon next to the content reviewer's alias. If you can't add labels, add a comment with #feedback-addressed to the pull request.
  • After the content review is complete, your reviewer will add the content review complete label. When the updates in this PR are ready for external customers to use, replace the do not merge label with ready to merge and the PR will be merged within 24 working hours.
  • Pull requests that are inactive for more than 6 weeks will be automatically closed. Before that, you receive reminders at 2 weeks, 4 weeks, and 6 weeks. If you still need the PR, you can reopen or recreate the request.

For more information, see the Content review process summary.

@learn-build-service-prod
Copy link
Contributor

Copy link
Contributor

@FaithOmbongi FaithOmbongi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sbreingold-ms -

Your proposed changes has brought to light a few errors in the documentation aside from those you're trying to fix.

According to the schema, secureScoreControlProfile doesn't define the assignedTo, state, and comment properties that are mentioned in the [Update doc](Update secureScoreControlProfile - Microsoft Graph v1.0 | Microsoft Learn). You'll also see the three properties are not documented in the resource topic. Likely, this was an error during content review - we only document properties that are public. (Or am I missing something?)

image.png

You can confirm from the deployed schemas:

So the right course of action is to delete those 3 properties from the table and all the payloads.

LMK if you have concerns about this course of action.


On another note, the code snippets are autogenerated. Once we delete those three properties from the payloads, the code snippets will be autogenerated on the next Tuesday.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 4c94985:

✅ Validation status: passed

File Status Preview URL Details
api-reference/v1.0/api/securescorecontrolprofile-update.md ✅Succeeded
api-reference/v1.0/includes/snippets/csharp/securescorecontrolprofiles-update-1-csharp-snippets.md ✅Succeeded
api-reference/v1.0/includes/snippets/csharp/securescorecontrolprofiles-update-2-csharp-snippets.md ✅Succeeded
api-reference/v1.0/includes/snippets/go/securescorecontrolprofiles-update-1-go-snippets.md ✅Succeeded
api-reference/v1.0/includes/snippets/go/securescorecontrolprofiles-update-2-go-snippets.md ✅Succeeded
api-reference/v1.0/includes/snippets/java/securescorecontrolprofiles-update-1-java-snippets.md ✅Succeeded
api-reference/v1.0/includes/snippets/java/securescorecontrolprofiles-update-2-java-snippets.md ✅Succeeded
api-reference/v1.0/includes/snippets/javascript/securescorecontrolprofiles-update-1-javascript-snippets.md ✅Succeeded
api-reference/v1.0/includes/snippets/javascript/securescorecontrolprofiles-update-2-javascript-snippets.md ✅Succeeded
api-reference/v1.0/includes/snippets/php/securescorecontrolprofiles-update-1-php-snippets.md ✅Succeeded
api-reference/v1.0/includes/snippets/php/securescorecontrolprofiles-update-2-php-snippets.md ✅Succeeded
api-reference/v1.0/includes/snippets/powershell/securescorecontrolprofiles-update-1-powershell-snippets.md ✅Succeeded
api-reference/v1.0/includes/snippets/powershell/securescorecontrolprofiles-update-2-powershell-snippets.md ✅Succeeded
api-reference/v1.0/includes/snippets/python/securescorecontrolprofiles-update-1-python-snippets.md ✅Succeeded
api-reference/v1.0/includes/snippets/python/securescorecontrolprofiles-update-2-python-snippets.md ✅Succeeded

For more details, please refer to the build report.

Copy link
Contributor

@FaithOmbongi FaithOmbongi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbreingold-ms - I'll merge this PR so that the code snippets tooling which runs every Tuesday morning might pick up the changes tomorrow and fix the autogenerated code snippets.

@FaithOmbongi FaithOmbongi added content review complete Apply when the content review is complete on a PR. ready to merge Use this label to indicate to the repository admins that your PR is ready to merge into master. and removed awaiting internal response blocked PRs that are blocked from content review or getting merged for some reason. changes requested content review in progress labels Dec 22, 2025
@FaithOmbongi FaithOmbongi merged commit 14e1ba9 into microsoftgraph:main Dec 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: security content review complete Apply when the content review is complete on a PR. ready to merge Use this label to indicate to the repository admins that your PR is ready to merge into master.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants