-
Notifications
You must be signed in to change notification settings - Fork 464
wi-539396-remove-reviewed-secure-score #9759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wi-539396-remove-reviewed-secure-score #9759
Conversation
FaithOmbongi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sbreingold-ms -
Your proposed changes has brought to light a few errors in the documentation aside from those you're trying to fix.
According to the schema, secureScoreControlProfile doesn't define the assignedTo, state, and comment properties that are mentioned in the [Update doc](Update secureScoreControlProfile - Microsoft Graph v1.0 | Microsoft Learn). You'll also see the three properties are not documented in the resource topic. Likely, this was an error during content review - we only document properties that are public. (Or am I missing something?)
You can confirm from the deployed schemas:
So the right course of action is to delete those 3 properties from the table and all the payloads.
LMK if you have concerns about this course of action.
On another note, the code snippets are autogenerated. Once we delete those three properties from the payloads, the code snippets will be autogenerated on the next Tuesday.
|
Learn Build status updates of commit 4c94985: ✅ Validation status: passed
For more details, please refer to the build report. |
FaithOmbongi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbreingold-ms - I'll merge this PR so that the code snippets tooling which runs every Tuesday morning might pick up the changes tomorrow and fix the autogenerated code snippets.

Important
Required for API changes:
Add other supporting information, such as a description of the PR changes:
ADO task: https://dev.azure.com/msft-skilling/Content/_workitems/edit/539396
MSFT dev contacts: Sharon Weiner and Faith Ombongi
Important
The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.
After you've created your PR, expand this section for tips and additional instructions.
#feedback-addressedto the pull request.For more information, see the Content review process summary.