Skip to content

WIP language reference and supporting materials for Compact 1.0#693

Merged
pataei merged 51 commits intomainfrom
lang-ref-1.0
Mar 25, 2026
Merged

WIP language reference and supporting materials for Compact 1.0#693
pataei merged 51 commits intomainfrom
lang-ref-1.0

Conversation

@dybvig
Copy link
Copy Markdown
Contributor

@dybvig dybvig commented Mar 9, 2026

No description provided.

replaced all-keywords.mdx with compact-keywords.mdx and removed
all-keywords.html.
removed word-break: break-all from custom.css code {} to we don't get line
breaks within words and constants in inline code segments.
moved ledger-adt.mdx from static/language to docs/compact/reference.
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
midnight-wiki Ready Ready Preview, Comment Mar 25, 2026 5:22pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026

🚀 Preview Deployment

Deployment Ready

🔗 Preview URL: https://pr-693-midnight-docs.vercel.app

📝 Latest commit: 80985dc
Updated: Mar 25, 2026, 5:20 PM UTC


This preview updates automatically when you push new commits to this PR.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 9, 2026

CLA assistant check
All committers have signed the CLA.

custom.css to make the table rendering prettier.
dybvig added 2 commits March 10, 2026 06:57
because it doesn't work when included in <table ...>, only when
introduced outside of <table>...</table>
@pataei
Copy link
Copy Markdown
Contributor

pataei commented Mar 24, 2026

Looks good to me. Just a few minor suggestions.

Also, when previewing the doc, I noticed in the compact-reference.mdx doc that code blocks were missing padding and looked a bit weird. Is this intended? Otherwise, we might need to investigate it.

Here is a preview of what I'm referring to...

Image

Thanks @gyrationtechs for a quick turnaround. I'm double checking with @dybvig on the formatting of code snippets.

@pataei
Copy link
Copy Markdown
Contributor

pataei commented Mar 24, 2026

@gyrationtechs two follow up question:

Screenshot 2026-03-24 at 12 36 02 PM

@dybvig
Copy link
Copy Markdown
Contributor Author

dybvig commented Mar 24, 2026

The code blocks look good to me without padding, but if you prefer padding, we could go with something small like "padding: 4px". The default is too large for my taste and also sometimes provides less than adequate horizontal space for the code given that the size of the center window is limited.

@pataei
Copy link
Copy Markdown
Contributor

pataei commented Mar 24, 2026

The code blocks look good to me without padding, but if you prefer padding, we could go with something small like "padding: 4px". The default is too large for my taste and also sometimes provides less than adequate horizontal space for the code given that the size of the center window is limited.

@dybvig I applied this and propagated it back to lfdt/compact repo in the PR I have for TS target.

@gyrationtechs
Copy link
Copy Markdown
Contributor

@pataei

  1. The versioned (0.0.0) docs are deprecated and shouldn't be updated. We left them as historical data and are not actively updating any docs from the directory.
  2. Yes, we can do that. Just to clarify. Do you mean having a link in the top navbar that points to the /compact category? Or are you referring to having the link along with dropdown options to other Compact docs?

added border: node to code{};
added <div className="lang-ref"> ... </div> around the
content of explicit-disclosure.mdx and writing.mdx.
@dybvig
Copy link
Copy Markdown
Contributor Author

dybvig commented Mar 24, 2026

Actually, the problem is that the padding is included not only for the code blocks but also for code segments in the text, and that looks funny with anything even as high as 4px. 2px looks pretty good, so I've switched to that. I also set up explicit-disclosure.mdx and writing.mdx to use the lang-ref style.

@pataei
Copy link
Copy Markdown
Contributor

pataei commented Mar 24, 2026

@pataei

  1. Yes, we can do that. Just to clarify. Do you mean having a link in the top navbar that points to the /compact category? Or are you referring to having the link along with dropdown options to other Compact docs?

@gyrationtechs The former, I want Compact to appear at the top and to be linked to the same files that are used for the sidebar (still I want to keep Compact in the sidebar as well).

Also if you're happy with this PR can we get an approval and merge it and then do the change for having Compact on top of the page as well?

gyrationtechs
gyrationtechs previously approved these changes Mar 25, 2026
Copy link
Copy Markdown
Contributor

@gyrationtechs gyrationtechs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pataei I will make the site navigation changes in a separate PR.

@pataei pataei merged commit f708fda into main Mar 25, 2026
12 of 13 checks passed
@pataei pataei deleted the lang-ref-1.0 branch March 25, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants