Added WMS Provider, added support for POST data.#1
Open
dzwarg wants to merge 5 commits intomigurski:masterfrom
Open
Added WMS Provider, added support for POST data.#1dzwarg wants to merge 5 commits intomigurski:masterfrom
dzwarg wants to merge 5 commits intomigurski:masterfrom
Conversation
added 4 commits
December 13, 2011 09:56
Owner
|
Thanks! Do you have a WMS server I can use to test this before I merge? |
Author
|
I'm looking into finding one. I'll let you know shortly. |
Author
|
Hello migurski, I added a public WMS server test to my repo: dzwarg/modestmaps-py, in the wms_test.py script. This test fetches and draws one map with the default styling, then uses an SLD with the inverted rule set to render the second. Is this what you need to test, or do you need more information? Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello migurski,
I added a WMS provider to modestmaps-py. I modeled it closely after the examples I saw for the as3 version, but removed the bounds checking.
In addition to the new provider, I added support for POST-able data. In my use case, I needed to send SLD_BODY content to the WMS map server when generating the images. This was a very small change to the Provider base (I removed some redundant methods), and some simple checks in the Tile load method.
In addition, I changed the default mode of the tile images to be 'RGBA', since sometimes the alpha channel is important, when generating overlays, for example.
Thanks,
dzwarg