Skip to content

Conversation

@brg7910
Copy link

@brg7910 brg7910 commented Jan 16, 2026

Beanconqueror PR; graphefruit/Beanconqueror#969

Summary by CodeRabbit

  • New Features
    • Added support for capturing and tracking basket temperature and target temperature data during espresso shot analysis, enabling more detailed brew parameter monitoring.

✏️ Tip: You can customize this high-level summary in your review settings.

@brg7910 brg7910 marked this pull request as draft January 16, 2026 23:43
@coderabbitai
Copy link

coderabbitai bot commented Jan 16, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes add support for two new temperature-related data mappings (basketTemperatureFlow and targetTemperatureFlow) to the shot chart parsing system in the ShotChart::ParsedShot model, with corresponding test cases validating extraction of these temperature flows from Beanconqueror brew data.

Changes

Cohort / File(s) Change Summary
Temperature Flow Data Mapping
app/models/shot_chart/parsed_shot.rb
Added two new keys to DATA_LABELS_MAP and DATA_VALUES_MAP constants: basketTemperatureFlow maps to espresso_temperature_basket label, targetTemperatureFlow maps to espresso_temperature_goal label; both map to actual_temperature in values mapping.
Beanconqueror Parser Tests
test/models/parsers/beanconqueror_test.rb
Added two new test cases validating extraction of basketTemperatureFlow and targetTemperatureFlow from Beanconqueror JSON test data; tests verify presence, size, duration, and extra keys consistency.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Warm flows now dance in our charts so bright,
Basket and goal temps, captured just right,
Spring brings new data to measure espresso's delight! ☕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add extended temperature support for Beanconqueror' directly summarizes the main change: adding support for two new temperature-related data mappings (basketTemperatureFlow and targetTemperatureFlow) in the Beanconqueror parser, with corresponding tests validating this functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@miharekar
Copy link
Owner

Outside of RuboCop comments looks good to me. Let me know when it's mergeable.

@brg7910 brg7910 force-pushed the feature-beanconqueror-extended-temperature-support branch from 4f7a5a9 to 6473977 Compare January 17, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants