Skip to content

Move charts to stimulus #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miharekar merged 6 commits into from
Jan 30, 2026
Merged

Move charts to stimulus #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d01589
First pass
miharekar Jan 30, 2026
ae4ea2e
Extract helpers
miharekar Jan 30, 2026
866a5b8
Move stats too
miharekar Jan 30, 2026
518125f
Address review
miharekar Jan 30, 2026
5af724c
Fix shot chart annotation toggle
miharekar Jan 30, 2026
62400b6
Harden shot chart annotations
miharekar Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ group :development do
gem "bundler-audit"
gem "herb"
gem "hotwire-spark"
gem "htmlbeautifier"
gem "kamal"
gem "letter_opener"
gem "reactionview"
Expand Down
2 changes: 2 additions & 0 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ GEM
listen
rails (>= 7.0.0)
zeitwerk
htmlbeautifier (1.4.3)
i18n (1.14.8)
concurrent-ruby (~> 1.0)
image_processing (1.14.0)
Expand Down Expand Up @@ -595,6 +596,7 @@ DEPENDENCIES
factory_bot_rails
herb
hotwire-spark
htmlbeautifier
image_processing
importmap-rails
inline_svg
Expand Down
1 change: 0 additions & 1 deletion app/javascript/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,4 @@
import "@hotwired/turbo-rails"
import "@rails/activestorage"
import "controllers"
import "charts"
import "custom"
2 changes: 0 additions & 2 deletions app/javascript/charts/index.js
View file
Open in desktop

This file was deleted.

Loading