update SDL2 includes to work with Linux, build with CMake#6
Open
mboros1 wants to merge 2 commits intomikechambers84:masterfrom
Open
update SDL2 includes to work with Linux, build with CMake#6mboros1 wants to merge 2 commits intomikechambers84:masterfrom
mboros1 wants to merge 2 commits intomikechambers84:masterfrom
Conversation
…ild program with CMake, modifies README.md to reflect changes to build in Linux
Owner
|
Excellent! Thank you. CMake is something I never really got around to learning. I'm primarily a Windows guy, though I have a few servers and VMs running Linux. Let me give this a try on one of them. |
|
Hi @mboros1, why did you change SDL to SDL2 on Linux? I am going to integrate this project in an SDL1-only environment. It would be great if SDL1/SDL2 can be a compile-time option, rather than hardcoding SDL1 for Windows and SDL2 for everything else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, saw this project on reddit and it looks really cool. I saw you didn't have support for a Linux build system so I figured I could help by adding CMake build support, also allows someone to work on the project with CLion if they wanted to