Introduce CheckRunOptionBundle and centralize check run / delta-bundle option handling#404
Open
Introduce CheckRunOptionBundle and centralize check run / delta-bundle option handling#404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
check runandcheck delta-bundlecommand handlers by reifying the recurring option bundle as a typed dataclass and a small Decision Protocol.Description
CheckRunOptionBundledataclass to capture shared analysis/ASPF/lint/gate/baseline/status-watch inputs insrc/gabion/cli_support/check/check_commands.py.CheckRunDecisionProtocolandCheckRunDecisionResolutionto centralize baseline-mode validation and status-watch option assembly._check_run_runtime_kwargs_from_bundle(...)to convert the shared bundle into the single runtime kwargs surface consumed by the runtimerun_check_command_fn.register_check_run_commandandregister_check_delta_bundle_commandto build one sharedCheckRunOptionBundle, then map through the converter, with thedelta-bundlepath applying small explicit overrides (baselinedisabled,gate=none,lint_mode=none).test_check_run_and_delta_bundle_shared_option_parity_and_overridesintests/gabion/cli/cli_check_surface_edges_cases.pyasserting parity of shared flags and expected delta-bundle overrides.out/test_evidence.jsonto record the updated test-evidence mapping after the new test surface.Testing
PYTHONPATH=src:. python scripts/policy/policy_check.py --workflowswhich completed successfully after environment fallback (note: an initialmise execattempt failed due to localmise.tomltrust/toolchain resolution and was not used).PYTHONPATH=src:. python scripts/policy/policy_check.py --ambiguity-contractwhich succeeded.PYTHONPATH=src:. python -m pytest -o addopts='' tests/gabion/cli/cli_check_surface_edges_cases.py -qand observed32 passed.PYTHONPATH=src:. python -m scripts.misc.extract_test_evidence --root . --tests tests --out out/test_evidence.jsonand committed the refreshedout/test_evidence.jsonartifact.Codex Task