Skip to content

Conversation

@ncomerci
Copy link
Contributor

@ncomerci ncomerci commented Dec 29, 2025

What Changed:

  • Added mimic.yaml configuration file support for multi-task
  • Added MimicConfigHandler to load and validate mimic.yaml configurations
  • Added --include and --exclude flags to all CLI commands for task filtering
  • Maintained backward compatibility with single-task mode when mimic.yaml doesn't exist

@ncomerci ncomerci requested a review from lgalende December 29, 2025 16:01
@ncomerci ncomerci self-assigned this Dec 29, 2025
Copy link
Member

@lgalende lgalende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we do:

if (...) something()
// or
if (...) {
  somethingTooLongThatDoesNotFitOneLine()
}

but not:

if (...)
  somethingTooLongThatDoesNotFitOneLine()

Copy link
Member

@lgalende lgalende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about adding the following cases to the commands tests?

  • when the mimic config exists
  • when the mimic config does not exist

@lgalende
Copy link
Member

lgalende commented Jan 8, 2026

I know I requested it, but I've rolled back the constants to keep this PR clean. We can do it in a separate issue.

Copy link
Member

@lgalende lgalende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the command fails for one of the tasks, then the rest of the task aren't executed.
For example, if I want to deploy 10 tasks, and task-4 fails, then tasks 5 to 10 deployments don't run. Should they run anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants