-
Notifications
You must be signed in to change notification settings - Fork 1
CLI: Support multiple tasks #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
lgalende
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, we do:
if (...) something()
// or
if (...) {
somethingTooLongThatDoesNotFitOneLine()
}but not:
if (...)
somethingTooLongThatDoesNotFitOneLine()
lgalende
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT about adding the following cases to the commands tests?
- when the mimic config exists
- when the mimic config does not exist
|
I know I requested it, but I've rolled back the constants to keep this PR clean. We can do it in a separate issue. |
lgalende
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the command fails for one of the tasks, then the rest of the task aren't executed.
For example, if I want to deploy 10 tasks, and task-4 fails, then tasks 5 to 10 deployments don't run. Should they run anyway?
What Changed:
mimic.yamlconfiguration file support for multi-taskMimicConfigHandlerto load and validatemimic.yamlconfigurations--includeand--excludeflags to all CLI commands for task filteringmimic.yamldoesn't exist