Skip to content

Parse set var=ON #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Parse set var=ON #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mindsdb_sql_parser/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1755,6 +1755,10 @@ def constant(self, p):
def constant(self, p):
return Constant(value=False)

@_('ON')
def constant(self, p):
return Constant(value='ON', with_quotes=False)

@_('integer')
def constant(self, p):
return Constant(value=int(p.integer))
Expand Down
11 changes: 11 additions & 0 deletions tests/test_mindsdb/test_variables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,17 @@ def test_select_variable(self):
assert str(ast).lower() == sql.lower()
assert str(ast) == str(expected_ast)

def test_set(self):
for value in (0, 1, 'TRUE', 'FALSE', 'ON', 'OFF'):
sql = f"set @@session.autocommit={value}"
ast = parse_sql(sql)
expected_ast = Set(
name=Variable('session.autocommit', is_system_var=True),
value=Constant(value, with_quotes=False)
)
assert str(ast).lower() == sql.lower()
assert str(ast) == str(expected_ast)

def test_mysql(self):
sql = 'select @@session.auto_increment_increment, @@character_set_client'
ast = parse_sql(sql)
Expand Down
Loading