add skipLock option to window creation#110
Open
GameParrot wants to merge 1 commit intominecraft-linux:masterfrom
Open
add skipLock option to window creation#110GameParrot wants to merge 1 commit intominecraft-linux:masterfrom
GameParrot wants to merge 1 commit intominecraft-linux:masterfrom
Conversation
Member
|
I know the problem you are currently facing, but I'm still not happy with your approach of replacing a deadlock by data inconsistency errors that are hard to debug. Inconsistent data structures, by modifying collections that are used to iterate. I could rewrite the api so mcpelauncher_show_window and mcpelauncher_close_window no longer need to hold the lock that is used by the imgui render loop. Your mod can use std::thread to call them in a new thread with their parameters on the stack as well. |
Member
|
a recusive_mutex could fix the deadlock as well, but still has data inconsistency for closing / updating windows (create new is ok with a recusive mutex as I used a for loop with i). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds skipLock to mcpelauncher_show_window and mcpelauncher_close_window