[machine]:windows node setup #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iankingori
reviewed
Jan 8, 2025
iankingori
reviewed
Mar 3, 2025
iankingori
reviewed
Mar 3, 2025
iankingori
reviewed
Mar 5, 2025
TinaMor
reviewed
Apr 15, 2025
20 tasks
knabben
reviewed
Sep 1, 2025
knabben
reviewed
Sep 1, 2025
knabben
reviewed
Sep 1, 2025
Seema-Athmeeya
approved these changes
Sep 4, 2025
bdhobare
approved these changes
Sep 4, 2025
JuxhinDB
approved these changes
Sep 4, 2025
timmy-wright
reviewed
Sep 5, 2025
| if err := b2dutils.CopyIsoToMachineDir(d.Boot2DockerURL, d.MachineName); err != nil { | ||
| return err | ||
|
|
||
| if mcnutils.ConfigGuest.GetGuestOS() == "windows" { |
There was a problem hiding this comment.
It'd be nice if the ConfigGuest type had a "IsWindows()" method that we reuse throughout this change. I know it's just a comparison against a string, but this type of comparison changes over time.
timmy-wright
reviewed
Sep 5, 2025
| } | ||
| } | ||
|
|
||
| log.Infof("Starting VM...") |
There was a problem hiding this comment.
This seems like a useful logging message we're removing. Could even enhance it a bit with info about the VM we're starting.
timmy-wright
approved these changes
Sep 10, 2025
|
@bobsira Thankyou for the PR, I have tried this PR locally along with bobsira/minikube#4 , Looks good to me. Thanks |
msft-linliu
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this PR follow the steps below
Prerequisites (local machine)
1) Prepare local modules (temporary local replace)
Open
go.modin your localminikuberepo and temporarily replace thegithub.com/docker/machinemodule with your localminikube-machinepath.Before (example upstream replacement)
github.com/docker/machine => github.com/minikube-machine/machine v0.0.0-20240815173309-ffb6b643c381Temporary local replace( use a Windows absolute path)
Important: This replace is only for local testing. Remove or revert it before committing/pushing.
2) Build minikube
From the minikube repo root build with make (repo uses make target)
You should now have minikube.exe in the repo out directory
3) Start a hybrid cluster (elevated PowerShell)
Start using the default (built-in) VHD
.\minikube.exe start --kubernetes-version=v1.33.0 -n 2 --node-os='[linux,windows]'Start using a custom VHD (remote or local)
--windows-vhd-url accepts remote URLs or local absolute paths:Remote
.\minikube.exe start --kubernetes-version=v1.32.3 -n 2 --node-os='[linux,windows]' --windows-vhd-url='https://<your-storage>/hybrid-minikube-windows-server.vhdx'Local path
.\minikube.exe start --kubernetes-version=v1.32.3 -n 2 --node-os='[linux,windows]' --windows-vhd-url='C:\vhd\hybrid-minikube-windows-server.vhdx'4) What to expect
kubectl get nodes -o wideshould show two nodes with OS labels: one linux, one windows.Setting up the cluster
Verify your cluster
