This repository was archived by the owner on Mar 20, 2026. It is now read-only.
Add hostAliases support for Tenant#2508
Open
eXist-FraGGer wants to merge 1 commit intominio:masterfrom
Open
Conversation
Author
|
@cniackz, @harshavardhana, @pjuarezd, @ramondeklein Hello guys, please let's review this and discuss as it is very critical configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for
spec.hostAliasesinTenant(apiVersion: minio.min.io/v2) so custom/etc/hostsentries can be configured for MinIO pods.Changes included:
HostAliases []corev1.HostAliastoTenantSpechostAliasesinto MinIO StatefulSet PodSpecresources/base/crds/minio.min.io_tenants.yaml)tenant.hostAliasesinhelm/tenant/values.yamlspec.hostAliasesinhelm/tenant/templates/tenant.yamlWithHostAliases)Related Issue
relates: #1965
Type of Change
Screenshots (if applicable e.g before/after)
Checklist
Test Steps
Tenantwith:StatefulSetis reconciled.hostAliases/etc/hostscontains the configured hostname mapping.Additional Notes / Context
gofmtwas applied.go testwas applied forhelm templateconfirmed renderingspec.hostAliasesUse case:
Deployed in minikube
istio+minio+keycloakand configurehosted local domain zone(e.g.pdnsutil zone).The issue is to setup
oauth2at minio via keycloak (Own OIDC Provider):You can not use internal address
.svc.cluster.localbecause redirect url at browser will not resolve internal kubernetes address.So you are using
hosted local zonee.g.keycloak.dev.local, but it will be resolved to 127.0.0.1 - this is wrong and this is why we must havehostAliasesto configure hostnamekeycloak.dev.localtoistio ingress gateway cluster IP.