fix: prefer exact key name match over canonical header form in condition lookup#226
Open
harshavardhana wants to merge 1 commit intominio:mainfrom
Open
fix: prefer exact key name match over canonical header form in condition lookup#226harshavardhana wants to merge 1 commit intominio:mainfrom
harshavardhana wants to merge 1 commit intominio:mainfrom
Conversation
…ion lookup getValuesByKey() currently tries http.CanonicalHeaderKey(name) before the raw name. Reverse the order so that exact name matches take precedence, falling back to canonical header form only when needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getValuesByKey()to try exact key name match beforehttp.CanonicalHeaderKeyformTest plan
go test ./policy/condition/...passes (72 tests)