Add ledger support in CLI and GUI wallet #1949
Conversation
OBorce
force-pushed
the
feature/wallet-ledger
branch
from
f52653e to
dc1d594
Compare
OBorce
force-pushed
the
feature/wallet-ledger
branch
from
dc1d594 to
15cfdf6
Compare
OBorce
force-pushed
the
feature/ledger_signer_provider
branch
from
64b9b14 to
10d2120
Compare
OBorce
force-pushed
the
feature/wallet-ledger
branch
from
15cfdf6 to
5ea99a2
Compare
OBorce
force-pushed
the
feature/ledger_signer_provider
branch
from
10d2120 to
a8231af
Compare
OBorce
force-pushed
the
feature/ledger_signer_provider
branch
2 times, most recently
from
5b2cae2 to
2de6ff8
Compare
OBorce
force-pushed
the
feature/wallet-ledger
branch
from
5ea99a2 to
c1ef94c
Compare
OBorce
force-pushed
the
feature/ledger_signer_provider
branch
from
2de6ff8 to
d4a8f4d
Compare
OBorce
force-pushed
the
feature/wallet-ledger
branch
from
c1ef94c to
fd62a71
Compare
OBorce
force-pushed
the
feature/ledger_signer_provider
branch
from
d4a8f4d to
32a8870
Compare
OBorce
force-pushed
the
feature/wallet-ledger
branch
from
fd62a71 to
4a92938
Compare
OBorce
force-pushed
the
feature/ledger_signer_provider
branch
from
32a8870 to
39d3e58
Compare
OBorce
force-pushed
the
feature/wallet-ledger
branch
2 times, most recently
from
5235b5f to
ab3143a
Compare
| /// Create a wallet using a connected hardware wallet. Only the public keys will be kept in | ||
| /// the software wallet. Cannot specify a mnemonic or passphrase here, | ||
| /// the former must have been entered on the hardware during the device setup | ||
| /// and the latter will have to be entered every time the device is connected to the host machine. | ||
| #[command()] |
There was a problem hiding this comment.
-
In the GUI menu Ledger support has the "(Beta)" tag, same as Trezor.
-
Plz make sure that the command help looks nice and is consistent with the one for Trezor. Run wallet-cli and check how both doc strings look in
wallet-create --helpand how the outputs ofwallet-create trezor --helpandwallet-create ledger --helplook. Those empty lines are there for a reason. -
"and the latter will have to be entered every time the device is connected to the host machine" - this is not 100% correct for Ledger, because besides a temporary passphrase there can also be a "permanent" one, tied to a secondary PIN. So after you connect the device and enter the secondary PIN, the passphrase will come into effect, without the need to enter it again. I.e. we need to reformulate this for Ledger (or for both of them), I'm not yet sure how though.
OBorce
force-pushed
the
feature/ledger_signer_provider
branch
from
39d3e58 to
4c711b6
Compare
OBorce
force-pushed
the
feature/wallet-ledger
branch
from
ab3143a to
b66c972
Compare
No description provided.