Merged
Conversation
b473afb to
41a81db
Compare
DeanWay
approved these changes
Jul 22, 2025
DeanWay
left a comment
There was a problem hiding this comment.
You can apply these suggestions if you like but otherwise the solution works as is, LGTM
dvdvdmt
approved these changes
Jul 24, 2025
d514d1b to
22c3105
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When pasting text with a soft break in it near the end of a line, the soft break would (1) not be inserted and (2) the orignal preceeding characters would replace the soft breaks. For example
Document:
Change Delta:
{insert: '45[SOFT_LINE_BREAK]67'}Invalid outcome produced
01245367Investigation
The issue is in block.ts
After the first invocation of the loop, we should go into the first if statement but we don't because
i < this.length() - 1doesn't take into account the fact we have modified the document
Fix
Math.min(i, this.length() - 1 + addedChars);