Call url() with suitable options when generating $url from field_link#5
Open
alt36 wants to merge 1 commit intomisd-service-development:masterfrom
Open
Call url() with suitable options when generating $url from field_link#5alt36 wants to merge 1 commit intomisd-service-development:masterfrom
alt36 wants to merge 1 commit intomisd-service-development:masterfrom
Conversation
This follows the code in theme_link_formatter_link_plain() from link.module. When the raw internal 'url' property is simply printed, it leads to any query parameters being stripped (and I'm assuming e.g. that URL fragments are similarly missed off) because of the internals of how Link sanitizes URLs. This e.g. makes it impossible to have a carousel item linking to a YouTube video.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the code in theme_link_formatter_link_plain() from
link.module. When the raw internal 'url' property is simply
printed, it leads to any query parameters being stripped (and I'm
assuming e.g. that URL fragments are similarly missed off) because
of the internals of how Link sanitizes URLs.
This e.g. makes it impossible to have a carousel item linking to
a YouTube video.
NB I don't directly use the cambridge_carousel module, instead using a similar module for local purposes. However, this PR is a straight copy/paste from the change I've just deployed to my module (https://gitlab.developers.cam.ac.uk/ch/co/drupal-chem/chemistry_slideshow/-/commit/31fc72621907bac460380aeb1253b8819778f3fe)