Fix a compile error on JS target (fix #50)#51
Open
jgranick wants to merge 2 commits intomisprintt:masterfrom
Open
Fix a compile error on JS target (fix #50)#51jgranick wants to merge 2 commits intomisprintt:masterfrom
jgranick wants to merge 2 commits intomisprintt:masterfrom
Conversation
This was referenced Jan 18, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using an optional function parameter of a basic type (such as
Bool) results in compile errors.For example, adding to the
Calculatormock example:Results in this error:
Returning
nullas the default parameter on all dynamic targets formacro.tools.ComplexTypesresults in forcing typeBoolto beNull<Bool>, but this was not the original type. On current Haxe development builds, this is the error, on Haxe 3.2.1 it printed "src/Main.hx:28: characters 15-25 : math.CalculatorMocked has no field round" which is more confusing.Removing the
Tools.isStaticPlatform()conditional seems to fix this condition on JavaScript.