Skip to content
This repository was archived by the owner on Jul 15, 2024. It is now read-only.

modify type definition of notifications/read according to the implementation #59

Open
yuchiki wants to merge 3 commits into
base: develop
Choose a base branch
from
+1 −1
Open

modify type definition of notifications/read according to the implementation #59

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78aa4ae
modify type definition of notifications/read according to the impleme…
yuchiki Mar 15, 2023
c310084
fix
yuchiki Mar 29, 2023
734ce9c
revert auto indent
yuchiki Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ export type Endpoints = {
// notifications
'notifications/create': { req: { body: string; header?: string | null; icon?: string | null; }; res: null; };
'notifications/mark-all-as-read': { req: NoParams; res: null; };
'notifications/read': { req: { notificationId: Notification['id']; }; res: null; };
'notifications/read': { req: { notificationIds: Notification['id'][]; }; res: null; };
Copy link
Copy Markdown
Author

@yuchiki yuchiki Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notificationIds: Notification['id'][],

at https://github.com/misskey-dev/misskey/blob/42833cd9219cb8f5abd1756aa1c57b024b125710/packages/backend/src/core/NotificationService.ts#L27

Copy link
Copy Markdown
Member

@saschanaz saschanaz Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/misskey-dev/misskey/blob/42833cd9219cb8f5abd1756aa1c57b024b125710/packages/backend/src/server/api/endpoints/notifications/read.ts#L23-L44

実際には両方許可していますね

misskey-dev/misskey#10409 がマージされたらあとでそっちで修正した方が良さそうです

Copy link
Copy Markdown
Author

@yuchiki yuchiki Mar 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

理解しました。

そちらがmergeされたらhttps://github.com/misskey-dev/misskey/pull/10331　の中で修正します！


// page-push
'page-push': { req: { pageId: Page['id']; event: string; var?: any; }; res: null; };
Expand Down