Device selection fix #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Device selection (-s) must be directly after the ADB command.
Corrected logic error relating to commands without a device.
Contributor
|
Hey, I have re-read the code and just noticed that the command was in fact broken. The command syntax should have been following: |
Author
|
@Davis-3450 Didn't want to be someone that complained without fixing. However it works, and got me past my problem. Would be more than happy for you to adjust as per PEP 8 - that's why I @'d you! Thanks very much |
Contributor
|
Hey @quantum-x , take a look at #50 may you help me test it?, should be more robust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a slight bug in @Davis-3450's PR - Device selection (-s) must be directly after the ADB command.