chore(deps): update dependency social-auth-app-django to v5.6.0 [security]#3728
chore(deps): update dependency social-auth-app-django to v5.6.0 [security]#3728renovate[bot] wants to merge 1 commit intomasterfrom
Conversation
6190bb4 to
9859031
Compare
9859031 to
b48d71f
Compare
|
Will this PR require a migration? |
|
@pdpinch yes, there are a few django migrations that are added in this change http://github.com/python-social-auth/social-app-django/compare/5.4.3...5.7.0. Should I proceed with this? |
|
How many rows do you think this will affect in RC and in production? How long do you think it might take to run? Can the migration be reverted if we need to? After some recent changes we made, I don't expect the migration to be blocking while it's running. What do you think? |
|
@pdpinch Though there are changes in a few migration files, the only new migration I see, adds a NOT NULL constraint to the uid field in UserSocialAuth. It will scan all existing rows to validate the constraint, then add it. Since I've verified 0 null/empty uid values in RC and production, it should complete quickly (seconds to a few minutes max) and be non-blocking because no data changes are needed. Validation on RC (total 413 records): In [1]: from social_django.models import UserSocialAuth
In [2]: bad_count = UserSocialAuth.objects.filter(uid__isnull=True).count() + Us
⋮ erSocialAuth.objects.filter(uid='').count()
...: print(f"Records with null/empty uid: {bad_count}")
Records with null/empty uid: 0Validation on Production (total 166628 records): In [1]: from social_django.models import UserSocialAuth
In [2]: bad_count = UserSocialAuth.objects.filter(uid__isnull=True).count() + Us
⋮ erSocialAuth.objects.filter(uid='').count()
...: print(f"Records with null/empty uid: {bad_count}")
Records with null/empty uid: 0The migration can also be reversed, since it only adds a constraint that changes no rows, via |
|
Thanks @asajjad2. Seems like it will be OK to proceed. I would just recommend that you coordinate with @mitodl/devops to schedule the deployment to production. |
This PR contains the following updates:
5.4.3→5.6.0GitHub Vulnerability Alerts
CVE-2025-61783
Impact
Upon authentication, the user could be associated by e-mail even if the
associate_by_emailpipeline was not included. This could lead to account compromise when a third-party authentication service does not validate provided e-mail addresses or doesn't require unique e-mail addresses.Patches
Workarounds
Review the authentication service policy on e-mail addresses; many will not allow exploiting this vulnerability.
Release Notes
python-social-auth/social-app-django (social-auth-app-django)
v5.6.0Compare Source
Changed
SOCIAL_AUTH_ACTIVE_USERS_FILTERif your custom model does not have theis_activefieldAdded
RAISE_EXCEPTIONSandLOGIN_ERROR_URLcan be configured per backendv5.5.1Compare Source
Changed
v5.5.0Compare Source
Changed
uid.Configuration
📅 Schedule: Branch creation - "" in timezone US/Eastern, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled because a matching PR was automerged previously.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.