Skip to content

fix(deps): update dependency mitol-django-common to v2025.12.23.2#3828

Open
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/mitol-django-common-2025.x
Open

fix(deps): update dependency mitol-django-common to v2025.12.23.2#3828
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/mitol-django-common-2025.x

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Mar 3, 2026

This PR contains the following updates:

Package Change Age Confidence
mitol-django-common ==2025.8.19==2025.12.23.2 age confidence

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone US/Eastern, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
Copy link
Contributor Author

renovate bot commented Mar 3, 2026

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: uv.lock
Command failed: uv lock --upgrade-package mitol-django-common
Using CPython 3.13.12
  × No solution found when resolving dependencies:
  ╰─▶ Because your project depends on mitol-django-common==2025.12.23.2 and
      mitol-django-common==2025.12.23.2 depends on pytest>=9,<10, we can
      conclude that your project depends on pytest>=9,<10.
      And because mitxpro:dev depends on pytest>=8.0.0,<9, we can conclude
      that your project and mitxpro:dev are incompatible.
      And because your project requires your project and mitxpro:dev, we can
      conclude that your project's requirements are unsatisfiable.

@renovate renovate bot force-pushed the renovate/mitol-django-common-2025.x branch from a74eb17 to a1979bd Compare March 3, 2026 10:50
"ipython>=9.0.0,<10",
"mitol-django-authentication==2025.3.17",
"mitol-django-common==2025.8.19",
"mitol-django-common==2025.12.23.2",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The update to mitol-django-common may affect the @single_task decorator, but no tests exist to verify the locking mechanism, creating a risk of data corruption.
Severity: MEDIUM

Suggested Fix

Add integration tests for the Celery tasks that specifically validate the locking behavior of the @single_task decorator. These tests should attempt to run the same task concurrently for the same object and assert that only one task instance acquires the lock and executes. This will verify that the updated dependency has not introduced a regression.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: pyproject.toml#L41

Potential issue: The update to `mitol-django-common` could introduce breaking changes to
the `@single_task` decorator, which is used to prevent race conditions in four critical
Hubspot synchronization tasks. The current test suite does not verify the decorator's
locking behavior, as this functionality is mocked. If the decorator's implementation has
changed between versions, the existing tests would not detect the regression. This could
lead to concurrent task executions for the same object, potentially causing data
corruption or inconsistencies in Hubspot without any immediate application errors.

Did we get this right? 👍 / 👎 to inform future reviews.

@renovate renovate bot force-pushed the renovate/mitol-django-common-2025.x branch 4 times, most recently from 84d59fe to 5944298 Compare March 3, 2026 17:12
"ipython>=9.0.0,<10",
"mitol-django-authentication==2025.3.17",
"mitol-django-common==2025.8.19",
"mitol-django-common==2025.12.23.2",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Updating mitol-django-common may cause runtime errors if functions like usernameify or chunks were removed or changed, as they lack local fallbacks.
Severity: MEDIUM

Suggested Fix

Before merging, verify that the required functions (usernameify, create_user_with_generated_username, chunks) are still present and compatible in the new version of mitol-django-common. Consider refactoring the code to use the local versions of dict_without_keys and now_in_utc to remove unnecessary external dependencies.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: pyproject.toml#L41

Potential issue: The application relies on functions such as `usernameify`,
`create_user_with_generated_username`, and `chunks` imported from the
`mitol-django-common` library. This pull request updates this dependency to a new
version. If these functions were removed or their signatures changed in the new version,
it would cause runtime failures in critical parts of the application, including user
authentication and background tasks. Additionally, there are inconsistencies where
functions like `dict_without_keys` and `now_in_utc` are imported from this external
library despite having local implementations, creating an unnecessary dependency.

@renovate renovate bot force-pushed the renovate/mitol-django-common-2025.x branch from 5944298 to d9e4889 Compare March 3, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants