Added nested JSON object functionality to group directive#4
Open
ginogervasio wants to merge 1 commit intomkasa:masterfrom
Open
Added nested JSON object functionality to group directive#4ginogervasio wants to merge 1 commit intomkasa:masterfrom
ginogervasio wants to merge 1 commit intomkasa:masterfrom
Conversation
|
Raise it's PR. Very much needed functionality |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mkasa - Really awesome code. I just wanted to show you something I had to do for my side project in case you were open to the suggestion/found it useful. I basically needed to make a few changes to your
select_jsonfunction to do two things - 1. Return an empty string instead of raising an error to make the schema a bit more lenient and 2. Allow the group directive to handle a nested JSON object so that:Looking forward to hearing from you about this.