Skip to content

Conversation

@davidkoski
Copy link
Collaborator

@davidkoski davidkoski commented Dec 17, 2025

Proposed changes

  • LLMEval has more of a showcase of features and runtime statistics
  • this provides the minimum required to load a model and interact with it
  • also cleans up the xcodeproj (see Fix Xcode project #451)
  • removes VLMEval (redundant and wasn't maintained)
image

I updated the documentation to indicate which examples were more full featured and which ones were the minimal starting points. Both have uses.

@DePasqualeOrg FYI

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

- LLMEval has more of a showcase of features and runtime statistics
- this provides the minimum required to load a model and interact with it
- also cleans up the xcodeproj (see #451)
- removes VLMEval (redundant and wasn't maintained)
@davidkoski davidkoski requested a review from awni December 17, 2025 22:00
self.task = nil
}
}
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the next file (ContentView) are the full minimal chat app.

### Troubleshooting

If the program crashes with a very deep stack trace, you may need to build
in Release configuration. This seems to depend on the size of the model.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This advice was obsolete

@@ -1,6 +1,5 @@
// Copyright © 2025 Apple Inc.

import AsyncAlgorithms
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used

.product(name: "MLXNN", package: "mlx-swift"),
.product(name: "MLXOptimizers", package: "mlx-swift"),
.product(name: "MLXRandom", package: "mlx-swift"),
.product(name: "Transformers", package: "swift-transformers"),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used

davidkoski added a commit to ml-explore/mlx-swift-lm that referenced this pull request Dec 18, 2025
- ml-explore/mlx-swift-examples#454

- fixes #27
- move ChatSession integration tests into new test target so we can more easily control when it runs
- make a ChatSession _unit_ (more or less) test
- fix Sendable / thread safety issues uncovered by LLMBasic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants