Skip to content

Fix all the [KMGT]B to be [KMGT]iB#307

Open
FileSystemGuy wants to merge 2 commits intomainfrom
fix-units
Open

Fix all the [KMGT]B to be [KMGT]iB#307
FileSystemGuy wants to merge 2 commits intomainfrom
fix-units

Conversation

@FileSystemGuy
Copy link
Copy Markdown
Contributor

The users were not sure whether "GB" was base 10 number or a base 2 number, so all printf's and log messages now include the "i" to show they are base 2 units.

@FileSystemGuy FileSystemGuy requested review from a team April 2, 2026 21:40
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Copy Markdown
Contributor

@russfellows russfellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I already approved this, but perhaps not. So now I have.

Copy link
Copy Markdown
Contributor

@idevasena idevasena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants