Prepend "uv run" to every "mlpstorage" invocation#308
Prepend "uv run" to every "mlpstorage" invocation#308FileSystemGuy wants to merge 6 commits intomainfrom
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
Resolve #293 |
russfellows
left a comment
There was a problem hiding this comment.
This makes sense to me. One possible alternative is a new shell script, which simply does a "uv run xxx.py" or whatever. This change is fine, but if people have heartburn that may be an easy solution?
|
I see following issue with VERSION METADATA Mismatch. Can be fixed as follows: Either: Before: After above change: |
idevasena
left a comment
There was a problem hiding this comment.
Overall following updates to be made:
pyproject.tomlLine 49:[project.scripts]→mlpstorage.main:mainshould bemlpstorage_py.main:mainpyproject.tomlLine 46:[tool.setuptools.package-data]key"mlpstorage"should be"mlpstorage_py"mlpstorage_py/__init__.py:_pkg_version("mlpstorage_py")mismatches distribution name"mlpstorage"mlpstorage_py/rules/verifier.pyline 73: String check"mlpstorage.benchmarks."not updated — breaks all benchmark runs.pyproject.tomlline 61:[tool.coverage.run]source still"mlpstorage"mlpstorage_py/main.py,mlpstorage_py/validation_helpers.py: User-facing messages, suggestions and print logs saymlpstorage_py instead ofmlpstorage`.
Updated project dependencies and script entry point to reflect the directory rename from mlpstorage to mlpstorage_py. Also make DLIO a required dependency rather than an optional one.
Missed a conversion from "mlpstorage." to "mlpstorage_py."
Missed a conversion from "mlpstorage." to "mlpstorage_py."
Accidentally convert some user-facing string to "mlpstorage_py", so undo that.
Accidentally convert some user-facing string to "mlpstorage_py", so undo that.
|
Thank you very much for such a detailed and thorough review! |
Insert a "mlpstorage" shell script to prepend "uv run" to every invocation, ensuring that the virtual environment with all the locked-down versions of libraries and tools is instantiated and used every single time.