Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help mmetc manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help mmetc manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…mon teardown hang - wait-for: add force-kill timer (SIGKILL after 2s) when matched process ignores SIGTERM, preventing asyncio.wait from blocking indefinitely - wait-for: preserve match status in TimeoutError handler instead of unconditionally returning 241 - crowdsec-daemon: add 5s bounded wait in stop() with SIGKILL escalation, preventing teardown hang when daemon is stuck in shutdown loop - Add regression test for slow-shutdown scenario in 00_wait_for.bats Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix nilerr lint: when ctx.Err() != nil, return the context error instead of silently swallowing it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add nolint:contextcheck for context.Background() in server.Shutdown(). Using a fresh context is correct here since the parent ctx is already cancelled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove ctx field from LokiClient struct and the redundant lc.ctx.Done() select cases. The stored context was always a parent of (or identical to) the method parameter context, making it redundant. Also use errors.Is() for context.Canceled comparison in tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove ctx field from VLClient struct and the redundant lc.ctx.Done() select cases. Close resp.Body in Tail() error path and add defer close in the reading goroutine. Explicitly ignore Stream() error in test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…entlog test API - kafka ReadMessage: return nil instead of ctx.Err() on context cancellation, consistent with other acquisition modules - wineventlog test: replace removed StreamingAcquisition with Stream, use context.WithCancel instead of tomb.Tomb Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.