feat: remove supports-color dependency #5471
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent! I'm mildly curious if we can add some sort of test for this? Otherwise I'll just test locally and see what I can repro. Thanks for this find! |
mark-wiemer
approved these changes
Sep 30, 2025
JoshuaKGoldberg
requested changes
Sep 30, 2025
There was a problem hiding this comment.
I like the removal of the dependency & unification to just the one checker... but the should not output colors to pipe is failing consistently in CI. Could you please take a look?
Interestingly, it doesn't fail for me locally. This might be related to alexeyraspopov/picocolors#41 <- actions/runner#241? alexeyraspopov/picocolors#87 fixed a bunch of issues.
|
Looks like |
JoshuaKGoldberg
added
the
status: blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
supports-colornow that we have picocolors #5470status: accepting prsOverview
This PR removes the
supports-colordependency and instead uses theisColorSupportedexport from picocolors. This saves on install size and ensures consistency between our use of color and picocolors' use of it.