Fixes #73. #83
Open
Fixes #73. #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if command response is for fd 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if command response is for fd 1.
The PR fixes issue #73 by checking if the target id for command responses is
1and if so, prints to stdout. This assumes stdout is '1' in the same way asinteractive_mode()does. There is a risk that mod-host may be launched without stdout being defined as '1' and the socket having fd=1 in which case this fix wouldn't work, but the full fix is a more substantial refactor of the code to correct a lot of other assumptions. This is a pragmatic fix to allow users to use the CLI that is currently broken.