-
Notifications
You must be signed in to change notification settings - Fork 598
Add examples of icons on tools, resources, prompts, and server implementation to EverythingServer #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Nice one! I am curious by the way, if there is still a goal to align this EverythingServer with the reference one? If so, then it might make sense to mirror what they do at modelcontextprotocol/servers#3121. |
|
@PederHP I did not realize there was a reference server in that repo. I'll investigate ... |
|
@mikekistler thanks for the reminder, I had planned to add icons, was just trying to get the base functionality refactored to a more maintainable shape that utilizes the latest TS SDK apis. |
302e010 to
8ad9d68
Compare
|
I'm going to revise this to minimize the divergence from the reference implementation of the EverythingServer. |
|
Flipping back out of draft now. The complex icons are now added to the existing Echo tool. |
halter73
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we want to use the commit sha in case the icons move. It's supposed to be stable on the main branch, I'm fine with keeping it as is.
Co-authored-by: Stephen Halter <halter73@gmail.com>
1860864 to
7a14300
Compare
Motivation and Context
This PR adds examples of icons for tools, resources, and prompts to the EverythingServer. It also adds icons and metadata to the server implementation. This illustrates the icons and metadata features added to the 2025-11-25 version of the MCP spec by SEP-973.
How Has This Been Tested?
I started the EverythingServer and connected to it with the MCP Inspector, and could see the icons associated with the weather tool and add tool, the direct resource, and simple prompt. The inspector also shows the icons for the server but does not display the other server metadata.
Breaking Changes
None.
Types of changes
Checklist
Additional context