Make Repository field properly optional in server.json #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
domdomegg
approved these changes
Oct 29, 2025
Swathi-MuraliSrinivasan
pushed a commit
to Swathi-MuraliSrinivasan/paychex-mcp-registry
that referenced
this pull request
Nov 20, 2025
…rotocol#717) <!-- Provide a brief summary of your changes --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> The Repository field in ServerJSON was not properly omitting empty values when marshaling to JSON. Even when a server had no repository configured, the JSON would include `"repository": {"url": "", "source": ""}` due to: 1. Repository struct fields (URL, Source) lacking omitempty tags 2. Repository being a value type instead of pointer in ServerJSON This caused validation warnings for servers without repository URLs. Changes: - Add omitempty tags to Repository.URL and Repository.Source fields - Change ServerJSON.Repository from model.Repository to *model.Repository - Update validateRepository to handle nil pointers - Update all code creating Repository instances to use pointers Now, servers without repository information correctly omit the field entirely from JSON output, eliminating spurious validation warnings. ## How Has This Been Tested? <!-- Have you tested this in a real application? Which scenarios were tested? --> ## Breaking Changes <!-- Will users need to update their code or configurations? --> ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [ ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ ] My code follows the repository's style guidelines - [ ] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed ## Additional context <!-- Add any other context, implementation notes, or design decisions --> Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The Repository field in ServerJSON was not properly omitting empty values
when marshaling to JSON. Even when a server had no repository configured,
the JSON would include
"repository": {"url": "", "source": ""}due to:This caused validation warnings for servers without repository URLs.
Changes:
Now, servers without repository information correctly omit the field
entirely from JSON output, eliminating spurious validation warnings.
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context