Skip to content

Conversation

@DagBruck
Copy link
Contributor

@DagBruck DagBruck commented Jun 6, 2025

No description provided.

Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansOlsson
Copy link
Contributor

However, I think #266 should be merged first.

Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
dateModified = "2024-06-26 14:00:00Z",
Complex(version="4.1.0"),
Modelica(version="4.1.0"),
DymolaCommands(version="1.20")),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DagBruck I can only see DymolaCommands v1.19 in (current) Dymola 2025x Refresh 1, 2025-05-16.

@@ -1,5 +1,5 @@
within ;
package Modelica_LinearSystems2 "Modelica_LinearSystems2 (version 3.0.0) - Analysis, Synthesis and Modeling of Continuous and Discrete Linear Systems"
package Modelica_LinearSystems2 "Modelica_LinearSystems2 (version 3.0.1) - Analysis, Synthesis and Modeling of Continuous and Discrete Linear Systems"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit irresolute regarding the version number. simver.org says

MINOR version when you add functionality in a backward compatible manner
PATCH version when you make backward compatible bug fixes

Changeing dependency on MSL seems being backward compatible. But we have neither bug fix nor new features.
I can live with v3.0.1, just want to point this out.

@tobolar tobolar mentioned this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants