feat(mps-sync-plugin): allow to update binding for switching a branch #2221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 241 files 241 suites 46m 37s ⏱️ Results for commit 760e30f. ♻️ This comment has been updated with latest results. |
Contributor
JVM coverage report
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| fun getServerConnections(): List<IServerConnection> | ||
| fun getUsedServerConnections(): List<IServerConnection> | ||
| fun getBindings(): List<IBinding> | ||
| fun updateBinding(oldBranchRef: BranchReference, newBranchRef: BranchReference, resetLocalState: Boolean = false) |
Check warning
Code scanning / detekt
The function updateBinding is missing documentation. Warning
| @Synchronized | ||
| override fun updateBinding(oldBranchRef: BranchReference, newBranchRef: BranchReference, resetLocalState: Boolean) { | ||
| updateState { | ||
| it.bindings.none { it.key.branchRef == oldBranchRef } && |
Check warning
Code scanning / detekt
Name shadowed: implicit lambda parameter 'it' Warning
| } | ||
|
|
||
| @Test | ||
| fun `updateBinding with resetLocalState true only affects matching binding`() { |
Check warning
Code scanning / detekt
The function updateBinding with resetLocalState true only affects matching binding is too long (62). The maximum length is 60. Warning test
abstraktor
force-pushed
the
feature/update-binding
branch
from
d4335c9 to
9d0dc96
Compare
abstraktor
force-pushed
the
feature/update-binding
branch
from
9d0dc96 to
760e30f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.